Andreas Dilger wrote:
> On my FC8 install, ismounted.c fails to build because open(O_CREAT) is
> used without passing a mode. The following trivial patch fixes it.
You can add:
Acked-by: Eric Sandeen <sandeen@xxxxxxxxxx>
'cause it's an awful lot like the patch I sent for the same issue back
on 8/16 ;-) Guess I should have followed that up with a ping. (though
your 0600 mode is probably better than my 0644 was)
Andreas, did you also run into trouble with struct_io_manager's ->open
calls triggering this test?
I sent a patch for that,
[PATCH] rename ->open and ->close ops in struct_io_manager
too... maybe the glibc #define tricks got smarter and don't trigger that
now?
-Eric
> Signed-off-by: Andreas Dilger <adilger@xxxxxxxxx>
>
> Index: e2fsprogs-1.40.2/lib/ext2fs/ismounted.c
> ===================================================================
> --- e2fsprogs-1.40.2.orig/lib/ext2fs/ismounted.c
> +++ e2fsprogs-1.40.2/lib/ext2fs/ismounted.c
> @@ -147,7 +147,7 @@ static errcode_t check_mntent_file(const
> is_root:
> #define TEST_FILE "/.ismount-test-file"
> *mount_flags |= EXT2_MF_ISROOT;
> - fd = open(TEST_FILE, O_RDWR|O_CREAT);
> + fd = open(TEST_FILE, O_RDWR|O_CREAT, 0600);
> if (fd < 0) {
> if (errno == EROFS)
> *mount_flags |= EXT2_MF_READONLY;
>
> Cheers, Andreas
> --
> Andreas Dilger
> Sr. Software Engineer, Lustre Group
> Sun Microsystems of Canada, Inc.
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
