On Mon, Aug 13, 2007 at 11:32:57PM -0500, Jose R. Santos wrote: > From: Jose R. Santos <jrs@xxxxxxxxxx> > > Allow FLEX_BG to be use as a feature option at mke2fs time. > > @@ -1363,6 +1364,10 @@ static void PRS(int argc, char *argv[]) > fs_param.s_feature_ro_compat = 0; > } > > + if (fs_param.s_feature_incompat & > + EXT4_FEATURE_INCOMPAT_FLEX_BG) > + fs_param.s_feature_incompat |= EXT2_FEATURE_INCOMPAT_META_BG; > + > /* Set first meta blockgroup via an environment variable */ > /* (this is mostly for debugging purposes) */ > if ((fs_param.s_feature_incompat & EXT2_FEATURE_INCOMPAT_META_BG) && Why is this hunk here? Just for convenience, right? Technically there's no reason why we can't relax the location of the inode tables and bitmap blocks without going to meta_bg. My inclination is to keep the options as orthogonal as possible, and use mke2fs.conf to allow the user to conveniently set up filesystems with the appropriate configuration parameters. - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
