Aneesh Kumar K.V wrote: > We need to look at the default value and make sure > the mount options are not set via default value > before showing them via ext4_show_options Hm, does this jive with the comment about what's intended? /* * Show an option if * - it's set to a non-default value OR * - if the per-sb default is different from the global default */ Aren't you now omitting the option if it's set in the per-sb default? For example the "debug" option; it's off by default, globally. The above comment suggests that if you have overridden that global default in the per-sb "default mount options" then it should be shown; this sort of makes sense to me because tune2fs calls these "default mount options," I'd expect them to behave exactly as if you had explicitly mounted with them. With your patch, if you've set debug as default, it no longer shows up, right? -Eric - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
