On Thu, 11 Oct 2007 13:18:49 +0200 Jan Kara <jack@xxxxxxx> wrote: > +static inline __le16 ext2_rec_len_to_disk(unsigned len) > +{ > + if (len == (1 << 16)) > + return cpu_to_le16(EXT2_MAX_REC_LEN); > + else if (len > (1 << 16)) > + BUG(); > + return cpu_to_le16(len); > +} Of course, ext2 shouldn't be trying to write a bad record length into a directory entry. But are we sure that there is no way in which this situation could occur is the on-disk data was _already_ bad? Because it is very bad for a fileysstem to go BUG in response to unexpected data on the disk. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html