Re: [PATCH 01/13][e2fsprogs] Add initial checksum support.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



In crc16.h, this patch assumes that linux/types.h defines uint16_t.  

There are a couple of problems with this.  

#1) linux/types.h is non-portable, not only does it not exist on
 non-Linux systems, apparently on Ubuntu it's not always defining
 uint16_t.  On my Ubuntu gutsy system, it doesn't always get defined.

        CC ../../../lib/ext2fs/crc16.c
In file included from ../../../lib/ext2fs/crc16.c:10:
../../../lib/ext2fs/crc16.h:20: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘const’
../../../lib/ext2fs/crc16.h:22: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘crc16’


The right thing to do is to use ext2fs/ext2_types.h like everything
else in e2fsprogs, and use __u16 instead of uint16_t.

     		       	   	 	    - Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux