Avantika Mathur wrote:
Ext4: add new type ext4_grpnum_t, and change all group variables to this
type.
from: mathur@xxxxxxxxxx
In many places variables for block group are of type int, which limits the
maximum filesystem size. This patch introduces a new type
ext4_grpnum_t, of type unsigned long, to represent block group numbers
in ext4.
All occurrences of block group variables are converted to type
ext4_grpnum_t.
Hi avantika,
Just one little thing, you forgot to convert a variable type in balloc.c:
ext4_fsblk_t ext4_new_blocks_old(handle_t *handle, struct inode *inode,
ext4_fsblk_t goal, unsigned long *count, int *errp)
{
struct buffer_head *bitmap_bh = NULL;
struct buffer_head *gdp_bh;
ext4_grpnum_t group_no;
ext4_grpnum_t goal_group;
ext4_grpblk_t grp_target_blk; /* blockgroup relative goal
block */
ext4_grpblk_t grp_alloc_blk; /* blockgroup-relative
allocated block*/
ext4_fsblk_t ret_block; /* filesyetem-wide allocated
block */
int bgi; /* blockgroup iteration index */
^^^^^
Could you also remove, at the same time, the useless lines in this function:
#ifdef EXT4FS_DEBUG
static int goal_hits, goal_attempts;
#endif
... and:
ext4_debug("allocating block %lu. Goal hits %d of %d.\n",
ret_block, goal_hits, goal_attempts);
Just to clean up the code.
Thanks,
Valérie
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
