Theodore Tso wrote:
> On Thu, Sep 20, 2007 at 09:31:56AM -0500, Eric Sandeen wrote:
>
>> Agreed. If you think fsck shouldn't silently cope with this mistake,
>> and instead punish the user for it (it is what they asked for, after
>> all), I'm ok with that too. I'm willing to close my end as NOTABUG if
>> you don't want to take this patch. :)
>>
>
> I'm willing to take the patch, although I am thinking that it might be
> appropriate for fsck to print a warning message --- "Bind mount with
> non-zero fsck pass, skipping", or some such.
>
> What do you think?
>
> - Ted
>
Yup, was thinking the same.
----------------
An entry like this in /etc/fstab:
/foo /bar ext3 bind,defaults 1 3
will stop boot, as fsck.ext3 tries to check it and fails:
e2fsck 1.40.2 (12-Jul-2007)
fsck.ext3: Is a directory while trying to open /foo
The superblock could not be read or does not describe a correct ext2
filesystem. ...
Granted, asking for fsck of a bind mount in the fstab is a bit odd,
but it doesn't seem like it should stop the boot process if you make
this mistake.
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
Index: e2fsprogs-1.40.2/misc/fsck.c
===================================================================
--- e2fsprogs-1.40.2.orig/misc/fsck.c
+++ e2fsprogs-1.40.2/misc/fsck.c
@@ -867,6 +867,16 @@ static int ignore(struct fs_info *fs)
if (fs->passno == 0)
return 1;
+ /*
+ * If this is a bind mount, ignore it.
+ */
+ if (opt_in_list("bind", fs->opts)) {
+ fprintf(stderr,
+ _("Skipping bind mount on %s with nonzero fsck pass\n"),
+ fs->mountpt);
+ return 1;
+ }
+
interpret_type(fs);
/*
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
