Re: Sparse endian issues with patches.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sep 12, 2007  22:18 +0530, Aneesh Kumar K.V wrote:
> Attaching below patch that fix the sparse warning for ext4.

It would be good to also fix the "raw" access of split 48-bit and 64-bit
fields as I previously sent to the list.  A new typedef for these fields
(on disk) would ensure that they are not accessed directly and give
compiler warnings if new patches don't have the right macro usage.

> -				if (mnt_count != sbi->s_es->s_mnt_count) {
> +				if (mnt_count != le16_to_cpu(sbi->s_es->s_mnt_count)) {

That overflows 80 columns, as do several other lines.
> 

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux