Alex Tomas wrote: > Eric Sandeen wrote: >> +/* >> + * default stripe size = 1MB >> + */ >> +#define MB_DEFAULT_STRIPE 256 > > agree, though seems we'd better make it blocksize-insensitive Well, for now this isn't even used at *all* so might as well just remove it. >> +static int mb_find_extent(struct ext4_buddy *e3b, int order, int block, >> + int needed, struct ext4_free_extent *ex) >> >> how many "what" are needed? > > well, blocks :) I figured, though bytes is a possibility. :) In general, being explicit about units helps; xfs suffers a bit from byte/block/sector confusion in the code, in some places. >> Also there are a *lot* of BUGs and BUG_ONs added in this patch... are >> none of these recoverable? > > well, I'll review the code in this regard again, but most of them are not. > not that I like kernel panics, but BUG_ON() are very helpful to maintain > code, especially in long-term. Ok, I just think there might be upstream pushback on these, at one point at least they were trying to reduce the nr. of BUG calls in the code... Thanks, -Eric - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
