Re: [PATCH] placate checkpatch.pl to some degree for mballoc.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Andreas Dilger wrote:
> On Aug 31, 2007  16:28 -0500, Eric Sandeen wrote:
>> Here's a patch for mballoc.c, to make checkpatch happier with it.
>>
>> I was about as pedantic as I could be, except for a few things it 
>> complained about which I just could not agree with. :)
> 
> I'm happy with the changes, since I've adopted the kernel CodingStyle
> as my own, but not everyone at CFS has.
> 

...

>>
>> -Eric
>>
>> Make checkpatch happier with mballoc.c
>>
>> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> 
> You can add my "Signed-off-by: Andreas Dilger <adilger@xxxxxxxxxxxxx>"
> 
>> @@ -829,7 +845,8 @@ ext4_mb_mark_free_simple(struct super_bl
>> -			mb_clear_bit(first >> min, buddy + sbi->s_mb_offsets[min]);
>> +			mb_clear_bit(first >> min,
>> +					buddy + sbi->s_mb_offsets[min]);
> 
> Hmm, shouldn't "buddy" be aligned on the '(' from the previous line?

...

Yup, I did this a little bit fast & furious; I'll fix those up.

Thanks,

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux