Hello, > It is possible to panic the box by a race condition that exists in the > journalling code where we do not take the j_revoke_lock when traversing the > journal's revoked record list. This patch has been tested and we haven't seen > the issue yet, its a rather straightforward and correct (at least I think so :) > fix. Thank you, In principle, the patch looks fine. The only thing I'm wondering about is how that panic can happen... Journal write_revoke_records() is called from journal_commit_transaction() when revoke table for the committing transaction shouldn't see any further changes. So maybe the patch is masking a different problem. Do you have a way of reproducing the problem? Any stack trace available? Honza -- Jan Kara <jack@xxxxxxx> SuSE CR Labs - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
