On Aug 03, 2007 00:02 +0530, Aneesh Kumar K.V wrote: > Andreas Dilger wrote: > >Is this the mtime and UUID of the new filesystem or the old one? It > >should be the UUID and mtime of the new filesystem, so that the > >undo file can be verified against the current superblock. This poses > >a bit of a problem, because that information isn't saved until after > >the mke2fs run is finished. > > > >One possibility is to overwrite this information at the end of mke2fs > >after the new UUID and mtime are written? > > This can be done by writing the file system identity during the the > io_channel_close. > How about this patch on top of the last series. I will merge this into the > patcheset I thought about this also, but in fact for most uses of the undo manager we want to save the information at the start instead of the end, so it is possible to undo e.g. a partial e2fsck that crashes before it finishes. Only with mke2fs (and, I guess tune2fs -U) does the UUID change at the end. Also, can you check if mke2fs does any non-iomanager output? I think there is code to "zap" the old superblock at the start and old RAID info at the end of the block device, and I'm not sure if this uses the normal IO manager or not. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
