On Tue, Jul 24, 2007 at 04:35:02PM +0530, Girish Shilamkar wrote: > The patch changes the order that the config file and command line are parsed so > that command line has precedence. #1) Could you please wrap your patch headers at about coulmn 72 or so, please? Thanks!! #2) Changing when the config file is parsed doesn't change whether the command line or the config file has precendence. Parsing the config file merely sets up an in-memory parse tree so that C code can query the contents of the config file, e.g.: profile_get_boolean(ctx->profile, "options", "defer_check_on_battery", 0, 1, &defer_check_on_battery); Simply moving the profile_init() makes no difference. Also, none of the parameters in /etc/e2fsck.conf overlap with what you can specify on the command-line, so I'm not even sure what the original author (Jim Garlick) was even trying to get at. > It also adds a check to make sure only one -E > option is passed on the command line as -E option parsing is not cumulative. Yep, this is reasonable. - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
