On Mon, Jul 23, 2007 at 01:56:42PM -0700, Andrew Morton wrote: > On Mon, 23 Jul 2007 22:12:54 +0200 > Miklos Szeredi <miklos@xxxxxxxxxx> wrote: > > > From: Miklos Szeredi <mszeredi@xxxxxxx> > > > > Signed-off-by: Miklos Szeredi <mszeredi@xxxxxxx> > > Could we have changelogs for these patches, please? > > ie: what's wrong with the existing code, what change does this patch make? The idea is to allow /proc/mounts to display all of the mount options that were used to mount a particular filesystem. This is useful if you want /proc/mounts to replace /etc/mtab. I keep thinking that this is really the wrong approach, though, since it means adding a lot of coding to every single filesystem to reconstruct the mount options, and in some cases it will still never be enough to reconstruct exactly what was in /etc/mtab. (For example, the fully qualified domain named passed into some remote filesystem.) It seems to me the right answer would be to enhance the mount(2) system call with a new mount operation which would allow the user space mount command can stash exactly the options used to mount the filesystem. That we the kernel can store the exact ascii string in allocated memory and regurgitate it for the benefit of /proc/mounts, instead of adding a lot of code into ext2, ext3, ext4, et. al in an attempt partially reconstruct the mount options. - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
