Theodore Tso wrote: > On Fri, Jul 20, 2007 at 04:47:14PM -0500, Eric Sandeen wrote: >> For some odd geometries*, mkfs will try to allocate inode tables off >> the end of the block group and fail, rather than warning that too >> many inodes have been requested. >> >> This is because when ext2fs_initialize calculates metadata overhead, >> it is only adding in group descriptor blocks and the superblock >> if the *last* bg contains them - but the first bg also has all of >> the various metadata bits taking up space. >> >> Unconditionally adding those counts into the overhead seems to fix >> it properly. > > Yes, but it screws up the test right after that. We need to calculate > the overheads for both the first and last block group. When I respun > your patch and applied it to git, I fixed this. Yep, I missed that. Thanks for catching.... > I also added an explicit "Addresses-Red-Hat-Bugzilla: " entry to the > commit log. (This is mainly for your convenience when you're > cherry-picking patches.) Thanks, I appreciate that. > Finally, your patch didn't apply because you apparently nuked a > newline in the patch here: Urhg, sorry. Not sure how that happened. Thanks, -Eric - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
