On Jun 25, 2007 19:20 +0530, Amit K. Arora wrote: > @@ -2499,7 +2500,8 @@ long ext4_fallocate(struct inode *inode, > * currently supporting (pre)allocate mode for extent-based > * files _only_ > */ > - if (mode != FA_ALLOCATE || !(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL)) > + if (!(EXT4_I(inode)->i_flags & EXT4_EXTENTS_FL) || > + !(mode == FA_ALLOCATE || mode == FA_RESV_SPACE)) > return -EOPNOTSUPP; This should probably just check for the individual flags it can support (e.g. no FA_FL_DEALLOC, no FA_FL_DEL_DATA). I also thought another proposed flag was to determine whether mtime (and maybe ctime) is changed when doing prealloc/dealloc space? Default should probably be to change mtime/ctime, and have FA_FL_NO_MTIME. Someone else should decide if we want to allow changing the file w/o changing ctime, if that is required even though the file is not visibly changing. Maybe the ctime update should be implicit if the size or mtime are changing? Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
