Re: [PATCH] uninitialized groups ported - kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 20, 2007  17:26 +0530, Girish Shilamkar wrote:
>  			crc = crc16(crc, (__u8 *)gdp + offset,
> -				    sbi->s_es->s_desc_size - offset);
> +				    le16_to_cpu(sbi->s_es->s_desc_size)
> +					- offset);

Minor nit - please put '-' at the end of the previous line, and align
"offset" with '(sbi-> ...'.

Also, we're missing the signoff:

Signed-off-by: Andreas Dilger <adilger@xxxxxxxxxxxxx>
Signed-off-by: Girish Shilamkar <girish@xxxxxxxxxxxxx>


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux