On Jun 14, 2007 13:58 -0700, Mingming Cao wrote:
> On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote:
> > This patch converts the 32-bit i_version in the generic inode to a 64-
> > bit i_version field.
> >
> > Signed-off-by: Jean Noel Cordenner <jean-noel.cordenner@xxxxxxxx>
> > Signed-off-by: Kalpak Shah <kalpak@xxxxxxxxxxxxx>
> >
> > @@ -549,7 +549,7 @@ struct inode {
> > uid_t i_uid;
> > gid_t i_gid;
> > dev_t i_rdev;
> > - unsigned long i_version;
> > + uint64_t i_version;
> > loff_t i_size;
> > #ifdef __NEED_I_SIZE_ORDERED
> > seqcount_t i_size_seqcount;
> >
> >
>
>
> I think u64 is better here. It seems uint64_t is not defined in some
> cases and rarely being used.
Agreed.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
