Just updated the ext4 patch queue
http://repo.or.cz/w/ext4-patch-queue
Changes:
Added these three patches from Jose Santos:
ext4_set_jbd2_64bit_feature.patch
jbd2_config_jbd2_debug_fix.patch
jbd2_move_jbd2_debug_to_debugfs.patch
Reordered the series, move
jbd-stats-through-procfs and ext4_remove_subdirs_limit.patch before
delayed allocation patches
Run checkpatch.pl http://lwn.net/Articles/237451/
I fixed coding style issues for most patches by hand except the delayed
allocation patch ext4-delayed-allocation.patch. That need a bit more
work and requires someone family with the code better. Alex, can you
help on this? Attached is the checkpatch.pl output, thanks.
Mingming
printk() should include KERN_ facility level
#275: FILE: fs/ext4/writeback.c:73:
+#define wb_debug(fmt, a...) printk(fmt, ##a);
do not use assignment in condition
#338: FILE: fs/ext4/writeback.c:136:
+ while (!bio && (nr_vecs /= 2))
printk() should include KERN_ facility level
#826: FILE: fs/ext4/writeback.c:624:
+ printk("no mem for ext4_wb_pages!\n");
#if 0 -- if this code redundant remove it
#946: FILE: fs/ext4/writeback.c:744:
+#if 0
line over 80 characters
#948: FILE: fs/ext4/writeback.c:746:
+ printk("#%u: wow! short extent %d for flush on #%lu\n",
printk() should include KERN_ facility level
#948: FILE: fs/ext4/writeback.c:746:
+ printk("#%u: wow! short extent %d for flush on #%lu\n",
line over 80 characters
#949: FILE: fs/ext4/writeback.c:747:
+ (unsigned) current->pid, wc.len, inode->i_ino);
line over 80 characters
#950: FILE: fs/ext4/writeback.c:748:
+ printk("#%u: done = %d, nr_to_write %ld, sync = %d\n",
printk() should include KERN_ facility level
#950: FILE: fs/ext4/writeback.c:748:
+ printk("#%u: done = %d, nr_to_write %ld, sync = %d\n",
line over 80 characters
#951: FILE: fs/ext4/writeback.c:749:
+ (unsigned) current->pid, done, wbc->nr_to_write,
printk() should include KERN_ facility level
#953: FILE: fs/ext4/writeback.c:751:
+ printk("#%u: written %d, extents %d\n",
line over 80 characters
#954: FILE: fs/ext4/writeback.c:752:
+ (unsigned) current->pid, written, extents);
printk() should include KERN_ facility level
#955: FILE: fs/ext4/writeback.c:753:
+ printk("#%u: cur %lu, prev %lu\n",
#if 0 -- if this code redundant remove it
#985: FILE: fs/ext4/writeback.c:783:
+#if 0
line over 80 characters
#991: FILE: fs/ext4/writeback.c:789:
+ atomic_inc(&EXT4_SB(inode->i_sb)->s_wb_congested);
printk() should include KERN_ facility level
#1370: FILE: fs/ext4/writeback.c:1168:
+ printk("EXT4-fs: writeback: %d blocks %d extents in %d reqs (%d ave)\n",
line over 80 characters
#1375: FILE: fs/ext4/writeback.c:1173:
+ printk("EXT4-fs: writeback: %d nr_to_write, %d congestions, %d singles\n",
printk() should include KERN_ facility level
#1375: FILE: fs/ext4/writeback.c:1173:
+ printk("EXT4-fs: writeback: %d nr_to_write, %d congestions, %d singles\n",
printk() should include KERN_ facility level
#1379: FILE: fs/ext4/writeback.c:1177:
+ printk("EXT4-fs: writeback: %d collisions, %d single-page collisions\n",
printk() should include KERN_ facility level
#1382: FILE: fs/ext4/writeback.c:1180:
+ printk("EXT4-fs: writeback: %d allocated, %d dropped\n",
Missing Signed-off-by: line(s)
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
