Andreas Dilger wrote:
On Jun 11, 2007 18:42 +0200, Valerie Clement wrote:@@ -213,7 +213,11 @@ struct struct_ext2_filsys { int fragsize; dgrp_t group_desc_count; unsigned long desc_blocks; +#ifdef _EXT4FS_ + struct ext4_group_desc * group_desc; +#else struct ext2_group_desc * group_desc; +#endifThe way similar changes were incorporated into e2fsprogs in the past (e.g. large inode support) is to pass an ext2_group_desc around and in places where access to the "large" part of the struct are needed this is typecast and conditional upon the appropriate superblock field or feature, as it is in the kernel. This also avoids the need to change the parameter everywhere. This is important because even "ext4" filesystems may only have 32-byte group descriptors if they are formatted as ext3 and upgraded. For large inodes, this is using "s_inode_size", and for the group descriptor it should use "s_desc_size" and INCOMPAT_64BIT.
Yes, I see the problem. I'll make the changes in this way. Thanks, Valérie - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
