Re: [RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Jun 11, 2007  18:45 +0200, Valerie Clement wrote:
> +#define EXT2_BLOCK_BITMAP(bg)		\
> +	((bg)->bg_block_bitmap + ((__u64)(bg)->bg_block_bitmap_hi << 32))
> +#define EXT2_INODE_BITMAP(bg)		\
> +	((bg)->bg_inode_bitmap + ((__u64)(bg)->bg_inode_bitmap_hi << 32))
> +#define EXT2_INODE_TABLE(bg)		\
> +	((bg)->bg_inode_table  + ((__u64)(bg)->bg_inode_table_hi  << 32))
> +
> +
> +#define EXT2_BLOCK_BITMAP(bg)		(bg)->bg_block_bitmap
> +#define EXT2_INODE_BITMAP(bg)		(bg)->bg_inode_bitmap
> +#define EXT2_INODE_TABLE(bg)		(bg)->bg_inode_table

This patch could go straight into e2fsprogs without compatibility problems
if they were properly conditional upon INCOMPAT_64BIT and s_desc_size.

> @@ -95,6 +95,11 @@ void ext2fs_swap_group_desc(struct ext2_
>  	gdp->bg_flags = ext2fs_swab16(gdp->bg_flags);
>  	gdp->bg_itable_unused = ext2fs_swab16(gdp->bg_itable_unused);
>  	gdp->bg_checksum = ext2fs_swab16(gdp->bg_checksum);
> +#ifdef _EXT4FS_
> +	gdp->bg_block_bitmap_hi = ext2fs_swab32(gdp->bg_block_bitmap_hi);
> +	gdp->bg_inode_bitmap_hi = ext2fs_swab32(gdp->bg_inode_bitmap_hi);
> +	gdp->bg_inode_table_hi = ext2fs_swab32(gdp->bg_inode_table_hi);
> +#endif

Same comment.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux