On Tue, 2007-05-15 at 11:09 -0700, Badari Pulavarty wrote: > On Tue, 2007-05-15 at 19:15 +0200, Martin Michlmayr wrote: > > Building with GCC 4.2, I get the following error: > > > > CC [M] fs/ext4/extents.o > > fs/ext4/extents.c:2166: error: __ksymtab_ext4_ext_find_goal causes a section type conflict > > fs/ext4/extents.c:2163: error: __ksymtab_ext4_ext_invalidate_cache causes a section type conflict > > > > This is because ext4_ext_find_goal and ext4_ext_invalidate_cache are > > declared static but also exported. > > Hmm.. Why are these exported ? > Looking at the code > > > EXPORT_SYMBOL(ext4_ext_invalidate_cache); > EXPORT_SYMBOL(ext4_ext_insert_extent); > EXPORT_SYMBOL(ext4_ext_walk_space); > EXPORT_SYMBOL(ext4_ext_find_goal); > EXPORT_SYMBOL(ext4_ext_calc_credits_for_insert); > there is one more EXPORT_SYMBOL(ext4_mark_inode_dirty); And with fallocate() patch, EXPORT_SYMBOL(ext4_fallocate); > Mingming ? Why are we exporting these ? > Don't know. They should all used by ext4 only. Alex, can we remove these exported symbols? Mingming - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
