Re: [PATCH e2fsprogs] Restore backup superblocks in preen mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 08, 2007 at 06:43:24PM +0100, Daniel Drake wrote:
> The restoration of backup superblocks seems to be reversed in the current
> e2fsprogs:
> 
> When running without preen mode, e2fsck searches and locates a backup
> superblock and fixes the primary superblock without any user intervention.
> 
> When running in preen mode, e2fsck prints a message describing how the user
> can specify the location of a backup superblock, and exits without doing any
> repair.

That's intentional.  If the priumary superblock is wiped out,
something really bad has happened, and usually the first part of the
filesystem is gone too --- possibly including the first part of the
inode table, which would mean the root inode is gone.  So we do want
the user running e2fsck by hand.

We could argue about whether or not e2fsck should explicitly ask for
permission before using a backup superblock, and possibly printing the
label and validating the size, etc., before using it --- but we
definitely don't want to just blithly use a backup superblock when in
preen mode.

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux