Re: [PATCH] Accomodate 32-bit uid/guid values in e2fsprogs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Theodore Tso wrote:
On Mon, May 07, 2007 at 12:10:37PM -0500, Eric Sandeen wrote:
e2fsprogs doesn't handle large (> 16 bit) UID/GID...

Applied, with one correction:

--- e2fsprogs-hg.orig/misc/mke2fs.c
+++ e2fsprogs-hg/misc/mke2fs.c
@@ -492,9 +494,14 @@ static void create_root_dir(ext2_filsys _("while reading root inode"));
 			exit(1);
 		}
-		inode.i_uid = getuid();
-		if (inode.i_uid)
-			inode.i_gid = getgid();
+		uid = getuid();
+		inode.i_uid = uid;
+		inode.i_uid_high = uid >> 16;
+		if (inode.i_uid) {
		    ^^^^^^^^^^^

This should be "uid" instead.  Otherwise, the gid won't be set if the
uid is a multiple of 65536.

						- Ted

Doh... dumb mistake.  nice catch.  thanks.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Reiser Filesystem Development]     [Ceph FS]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite National Park]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]     [Linux Media]

  Powered by Linux