On Fri, Feb 09, 2007 at 06:11:26PM -0800, Brian D. Behlendorf wrote: > blkid_dev_has_tag() will immediately return -1 (an error if value is NULL. Thus > at the test later on value cannot be NULL. There are two possible ways to go > about fixing this. The first would be to remove the first NULL check for value. > The second one would be to remove the second check (and the deadcode). I could > be persuaded either way, but to preserve existing functionality I will opt to > remove the second check. Better to do this the other way, I think. It exposes more functionality, and there shouldn't be any code that depends on blkid_dev_has_tag returning an error is value is NULL. - Ted - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
