On Thu, 2007-02-15 at 23:46 -0800, Andrew Morton wrote: > On Fri, 16 Feb 2007 10:30:39 +0300 Alex Tomas <alex@xxxxxxxxxxxxx> wrote: > > hmm. I thought it has to call get_block() at least to know whether > > the block is already allocated. and I was going to reserve space > > in prepare_write for which some fs-specific method is needed becase > > only fs knows how much metadata it'd need. > > Well, one could just assume that the page has no disk mapping and go and > make the space reservation. Things will work out OK when we come to do > writepage(). > > Or one could do both: call get_block() only if the page was inside i_size. Or call get_block() with create = 0. Or replace the create argument with a flags field that can take either GET_BLOCK_CREATE or GET_BLOCK_RESERVE. -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html