>>>>> Andrew Morton (AM) writes: AM> Sorry, we're seriously, seriously, seriously short on flags in the page AM> struct and this patch is going to need one heck of a good case for it to be AM> acceptable. AM> Even then, we should put a lot of effort into finding some way of avoiding AM> adding that page flag. One option might be to add a new radix-tree tag, AM> and defining it as "for filesytem usage". Or use PG_checked (which should AM> be renamed to to PG_fs_misc) (if that doesn't conflict with ext4's existing AM> use of PG_checked). Or use !PageMappedToDisk()? there is a difference between being mapped and "booked". the latter means that page isn't allocated yet, but space is reserved (including metadata) and we're sure we'll be able to allocate space when the page is being flushed. AM> These patches seem to have a number of issues - we should get them properly AM> commented and properly changelogged then get them on the wire for decent AM> review before investing too much in them, please. I've been reworking the delayed allocation patch to move part of it into VFS. I'll try to comment things better this time. thanks, Alex - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
