Lawrence Livermore National Labs recently ran the source code analysis tool Coverity over the e2fsprogs-1.39 source to see if it would identify any significant bugs. The analysis turned up 38 mostly minor issues which are enumerated here with patches. We went through and resolved these issues but would love to see these mostly minor changes reviewed and commited upstream. Thanks, Brian Behlendorf <behlendorf1@xxxxxxxx>, and Herb Wartens <wartens2@xxxxxxxx> ----------------------------------------------------------------------------- Coverity ID: 26+27: Resource Leak zero_buf and buf must be freed on return from this function. The other potential resource leaks in this function are handled by calling exit(). Index: e2fsprogs+chaos/misc/e2image.c =================================================================== --- e2fsprogs+chaos.orig/misc/e2image.c +++ e2fsprogs+chaos/misc/e2image.c @@ -442,6 +442,8 @@ static void output_meta_data_blocks(ext2 } } write_block(fd, zero_buf, sparse, 1, -1); + free(zero_buf); + free(buf); } static void write_raw_image_file(ext2_filsys fs, int fd, int scramble_flag) - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
