Andreas Dilger wrote: > On Jan 12, 2007 14:45 -0600, Eric Sandeen wrote: >> p.s. ext3_inc_count and ext3_dec_count seem misnamed, have an unused >> arg, and are very infrequently called. I'll probably submit a patch >> to just put the single line of code into the caller, too. > > I use those functions in the > 32000 subdirs patch to handle the case > where a directory overflows the i_nlinks counter and needs to be set > to have i_nlinks = 1. > > Patch was posted previously, but rejected because there is a potential > for directory loss if the filesystem is mounted on an older kernel > (i_nlinks == 1, subdir is removed, directory is truncated). I need to > add an ROCOMPAT feature in order to handle this, but haven't gotten > around to doing it. Ah, ok. Sorry I'd missed that. Can we at least rename them to something that makes sense? :) -Eric > Cheers, Andreas > -- > Andreas Dilger > Principal Software Engineer > Cluster File Systems, Inc. > - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
