The Coverity checker noted that this was dead code, since in all places above in this function, "err" is immediately checked. Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx> --- linux-2.6/fs/ext4/extents.c.old 2006-11-06 11:02:09.000000000 +0100 +++ linux-2.6/fs/ext4/extents.c 2006-11-06 11:02:29.000000000 +0100 @@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand } /* insert new index */ - if (err) - goto cleanup; - err = ext4_ext_insert_index(handle, inode, path + at, le32_to_cpu(border), newblock); - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html