On Oct 26, 2006 18:02 +0200, Andre Noll wrote: > On 03:36, Andreas Dilger wrote: > > The other issue is that you need to potentially set "num" bits in the > > bitmap here, if those all overlap metadata. In fact, it might just > > make more sense at this stage to walk all of the bits in the bitmaps, > > the inode table and the backup superblock and group descriptor to see > > if they need fixing also. > > I tried to implement this, but I could not find out how to check at this > point whether a given bit (in the block bitmap, say) needs fixing. Well, since we know at least one bit needs fixing and results in the block being written to disk then setting the bits for all of the other metadata blocks in this group has no extra IO cost (only a tiny amount of CPU). Re-setting the bits if they are already set is not harmful. Cheers, Andreas -- Andreas Dilger Principal Software Engineer Cluster File Systems, Inc. - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
