On Wed, 2006-09-06 at 10:39 -0700, Badari Pulavarty wrote: > Index: linux-2.6.18-rc5/fs/ext3/inode.c > =================================================================== > --- linux-2.6.18-rc5.orig/fs/ext3/inode.c 2006-08-27 20:41:48.000000000 -0700 > +++ linux-2.6.18-rc5/fs/ext3/inode.c 2006-09-05 15:32:57.000000000 -0700 > @@ -1009,11 +1009,12 @@ struct buffer_head *ext3_getblk(handle_t > buffer_trace_init(&dummy.b_history); > err = ext3_get_blocks_handle(handle, inode, block, 1, > &dummy, create, 1); > - if (err == 1) { > + /* > + * ext3_get_blocks_handle() returns number of blocks > + * mapped. 0 in case of a HOLE. > + */ > + if (err > 0) { > err = 0; > - } else if (err >= 0) { > - WARN_ON(1); > - err = -EIO; > } I'd get rid of the {} too. > *errp = err; > if (!err && buffer_mapped(&dummy)) { -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html