> On Wed, 2006-09-06 at 14:47 +0200, Jan Kara wrote: > > > > Andrew, what should we do ? Do you suggest handling this in jbd > > > itself (like this patch) ? > > Actually that part of commit code needs rewrite anyway (and after that > > rewrite you get rid of ll_rw_block()) because of other problems - the > > code assumes that whenever buffer is locked, it is being written to disk > > which is not true... I have some preliminary patches for that but they > > are not very nice and so far I didn't have enough time to find a nice > > solution. > > Are you okay with current not-so-elegant fix ? Actually I don't quite understand how it can happen what you describe (so probably I missed something). How it can happen that some buffers are unmapped while we are committing them? journal_unmap_buffers() checks whether we are not committing truncated buffers and if so, it does not do anything to such buffers... Bye Honza -- Jan Kara <jack@xxxxxxx> SuSE CR Labs - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
