On 2/4/25 19:37, Petr Machata wrote: > Attempts to replace an MDB group membership of the host itself are > currently bounced: > > # ip link add name br up type bridge vlan_filtering 1 > # bridge mdb replace dev br port br grp 239.0.0.1 vid 2 > # bridge mdb replace dev br port br grp 239.0.0.1 vid 2 > Error: bridge: Group is already joined by host. > > A similar operation done on a member port would succeed. Ignore the check > for replacement of host group memberships as well. > > The bit of code that this enables is br_multicast_host_join(), which, for > already-joined groups only refreshes the MC group expiration timer, which > is desirable; and a userspace notification, also desirable. > > Change a selftest that exercises this code path from expecting a rejection > to expecting a pass. The rest of MDB selftests pass without modification. > > Signed-off-by: Petr Machata <petrm@xxxxxxxxxx> > Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx> > --- > net/bridge/br_mdb.c | 2 +- > tools/testing/selftests/net/forwarding/bridge_mdb.sh | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>