Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Subject: Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'
From: Jakub Kicinski <kuba@xxxxxxxxxx>
Date: Tue, 17 Dec 2024 19:03:59 -0800
Cc: Roopa Prabhu <roopa@xxxxxxxxxx>, Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxx>, Andrew Lunn <andrew@xxxxxxx>, Heiner Kallweit <hkallweit1@xxxxxxxxx>, Russell King <linux@xxxxxxxxxxxxxxx>, Kalle Valo <kvalo@xxxxxxxxxx>, Manish Chopra <manishc@xxxxxxxxxxx>, Rahul Verma <rahulv@xxxxxxxxxxx>, GR-Linux-NIC-Dev@xxxxxxxxxxx, Andrew Lunn <andrew+netdev@xxxxxxx>, Shahed Shaikh <shshaikh@xxxxxxxxxxx>, bridge@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-wireless@xxxxxxxxxxxxxxx
In-reply-to: <20241216-sysfs-const-bin_attr-net-v1-5-ec460b91f274@weissschuh.net>
References: <20241216-sysfs-const-bin_attr-net-v1-0-ec460b91f274@weissschuh.net> <20241216-sysfs-const-bin_attr-net-v1-5-ec460b91f274@weissschuh.net>

On Mon, 16 Dec 2024 12:30:12 +0100 Thomas Weißschuh wrote:
> -	.read = qlcnic_sysfs_read_pci_config,
> -	.write = NULL,
> +	.read_new = qlcnic_sysfs_read_pci_config,
> +	.write_new = NULL,

Please delete the NULL assignment instead.

References:
- [PATCH net-next 0/5] net: constify 'struct bin_attribute'
  - From: Thomas Weißschuh
- [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'
  - From: Thomas Weißschuh

Prev by Date: [PATCH net-next v2 2/2] net: bridge: add skb drop reasons to the most common drop points
Next by Date: Re: [PATCH net-next 0/5] net: constify 'struct bin_attribute'
Previous by thread: Re: [PATCH net-next 5/5] qlcnic: constify 'struct bin_attribute'
Next by thread: [PATCH net-next 1/5] net: bridge: constify 'struct bin_attribute'
Index(es):
- Date
- Thread

[Index of Archives] [Netdev] [AoE Tools] [Linux Wireless] [Kernel Newbies] [Security] [Linux for Hams] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux RAID] [Linux Admin] [Samba] [Video 4 Linux]