On Fri, Nov 08, 2024 at 04:24:18PM +1300, Elliot Ayrey wrote:
> The fdb sticky flag is used to stop a host from roaming to another
> port. However upon receiving a switchdev notification to update an fdb
> entry the sticky flag is not respected and as long as the new entry is
> not locked the host will be allowed to roam to the new port.
>
> Fix this by considering the sticky flag before allowing an externally
> learned host to roam.
>
> Signed-off-by: Elliot Ayrey <elliot.ayrey@xxxxxxxxxxxxxxxxxxx>
> ---
> net/bridge/br_fdb.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
So you have a sticky fdb entry added, but it is still allowed to roam in HW?
> diff --git a/net/bridge/br_fdb.c b/net/bridge/br_fdb.c
> index 1cd7bade9b3b..d0eeedc03390 100644
> --- a/net/bridge/br_fdb.c
> +++ b/net/bridge/br_fdb.c
> @@ -1457,7 +1457,8 @@ int br_fdb_external_learn_add(struct net_bridge *br, struct net_bridge_port *p,
>
> fdb->updated = jiffies;
>
> - if (READ_ONCE(fdb->dst) != p) {
> + if (READ_ONCE(fdb->dst) != p &&
> + !test_bit(BR_FDB_STICK, &fdb->flags)) {
> WRITE_ONCE(fdb->dst, p);
> modified = true;
> }
