On June 4, 2024 4:57:12 PM GMT+03:00, Paolo Abeni <pabeni@xxxxxxxxxx> wrote: >On Fri, 2024-05-31 at 16:54 +0800, Chen Hanxiao wrote: >> Smatch complains: >> net/bridge/br_netlink_tunnel.c: >> 318 br_process_vlan_tunnel_info() warn: inconsistent indenting >> >> Fix it with a proper indenting >> >> Signed-off-by: Chen Hanxiao <chenhx.fnst@xxxxxxxxxxx> > >My take is that purely format changes should be part of >larger/features-based change, to avoid any later stable fix harder for >no real reason. > >Thanks, > >Paolo > This is new, I don't see anything wrong with fixing bad indentation. Waiting for a set which touches this code which hasn't changed for a long time ib order to fix it is doesn't sound good to me. It is very trivial to resolve for anyone. Cheers, Nik