Re: [PATCH] bridge: vlan: fix compressvlans manpage and usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/22/24 10:56, Date Huang wrote:
Add the missing 'compressvlans' to man page.
Fix the incorrect short opt for compressvlans and color
in usage.

Signed-off-by: Date Huang <tjjh89017@xxxxxxxxxxx>
---

Hi,
This should be targeted at iproute2. Nit below,

  bridge/bridge.c   | 2 +-
  man/man8/bridge.8 | 5 +++++
  2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/bridge/bridge.c b/bridge/bridge.c
index f4805092..345f5b5f 100644
--- a/bridge/bridge.c
+++ b/bridge/bridge.c
@@ -39,7 +39,7 @@ static void usage(void)
  "where  OBJECT := { link | fdb | mdb | vlan | vni | monitor }\n"
  "       OPTIONS := { -V[ersion] | -s[tatistics] | -d[etails] |\n"
  "                    -o[neline] | -t[imestamp] | -n[etns] name |\n"
-"                    -c[ompressvlans] -color -p[retty] -j[son] }\n");
+"                    -compressvlans -c[olor] -p[retty] -j[son] }\n");
  	exit(-1);
  }
diff --git a/man/man8/bridge.8 b/man/man8/bridge.8
index eeea4073..9a023227 100644
--- a/man/man8/bridge.8
+++ b/man/man8/bridge.8
@@ -22,6 +22,7 @@ bridge \- show / manipulate bridge addresses and devices
  \fB\-s\fR[\fItatistics\fR] |
  \fB\-n\fR[\fIetns\fR] name |
  \fB\-b\fR[\fIatch\fR] filename |
+\fB\-compressvlans |
  \fB\-c\fR[\fIolor\fR] |
  \fB\-p\fR[\fIretty\fR] |
  \fB\-j\fR[\fIson\fR] |
@@ -345,6 +346,10 @@ Don't terminate bridge command on errors in batch mode.
  If there were any errors during execution of the commands, the application
  return code will be non zero.
+.TP
+.BR \-compressvlans
+Show compressed vlan list

s/vlan/VLAN/
also the explanation is lacking, please add a little bit of details and
what the default is

+
  .TP
  .BR \-c [ color ][ = { always | auto | never }
  Configure color output. If parameter is omitted or

Thanks,
 Nik





[Index of Archives]     [Netdev]     [AoE Tools]     [Linux Wireless]     [Kernel Newbies]     [Security]     [Linux for Hams]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux RAID]     [Linux Admin]     [Samba]     [Video 4 Linux]

  Powered by Linux