On 29/05/2023 14:48, Ido Schimmel wrote: > Adjust drivers that support the 'FLOW_DISSECTOR_KEY_META' key to reject > filters that try to match on the newly added layer 2 miss field. Add an > extack message to clearly communicate the failure reason to user space. > > The following users were not patched: > > 1. mtk_flow_offload_replace(): Only checks that the key is present, but > does not do anything with it. > 2. mlx5_tc_ct_set_tuple_match(): Used as part of netfilter offload, > which does not make use of the new field, unlike tc. > 3. get_netdev_from_rule() in nfp: Likewise. > > Example: > > # tc filter add dev swp1 egress pref 1 proto all flower skip_sw l2_miss true action drop > Error: mlxsw_spectrum: Can't match on "l2_miss". > We have an error talking to the kernel > > Acked-by: Elad Nachman <enachman@xxxxxxxxxxx> > Signed-off-by: Ido Schimmel <idosch@xxxxxxxxxx> > --- > > Notes: > v2: > * Expand commit message to explain why some users were not patched. > > .../net/ethernet/marvell/prestera/prestera_flower.c | 6 ++++++ > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++++ > drivers/net/ethernet/mellanox/mlxsw/spectrum_flower.c | 6 ++++++ > drivers/net/ethernet/mscc/ocelot_flower.c | 10 ++++++++++ > 4 files changed, 28 insertions(+) > Reviewed-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>
