On Mon, May 15, 2023 at 08:56:27AM -0700, Stephen Hemminger wrote:
> On Mon, 15 May 2023 10:50:46 +0200
> Johannes Nixdorf <jnixdorf-oss@xxxxxx> wrote:
>
> > +static struct ctl_table br_sysctl_table[] = {
> > + {
> > + .procname = "bridge-fdb-max-entries-default",
>
>
> That name is too long.
>
> Also, all the rest of bridge code does not use sysctl's.
The code in net/bridge/br_netfilter_hooks.c also uses sysctls, which is
where I took inspiration for the approach for setting them up, and also
the naming scheme.
> Why is this special and why should the property be global and not per bridge?
As explained in the commit message and [1] it is a global default
setting. It makes no sense to make it per bridge, as there is already
a per bridge netlink setting that overrides it. The only alternative
option is to not have it at all, which is what I will be going to do
with a v2.
> NAK
Fair enough. I took it out in my pending-v2-state of the series, but
would welcome some input on whether you see any value in the proposed
alternatives in [1], or are strictly against having a global default !=
0 here at all.
[1]: https://lore.kernel.org/netdev/20230515085046.4457-1-jnixdorf-oss@xxxxxx/T/#ma4145398516bfd39dfa09976b7892f5fdb76f8c0
