On 06/04/2023 14:30, yang.yang29@xxxxxxxxxx wrote: > From: xu xin <xu.xin16@xxxxxxxxxx> > > This creates six drop reasons as follows, which will help users know the > specific reason why bridge drops the packets when forwarding. > > 1) SKB_DROP_REASON_BRIDGE_FWD_NO_BACKUP_PORT: failed to get a backup > port link when the destination port is down. > > 2) SKB_DROP_REASON_BRIDGE_FWD_SAME_PORT: destination port is the same > with originating port when forwarding by a bridge. > > 3) SKB_DROP_REASON_BRIDGE_NON_FORWARDING_STATE: the bridge's state is > not forwarding. > > 4) SKB_DROP_REASON_BRIDGE_NOT_ALLOWED_EGRESS: the packet is not allowed > to go out through the port due to vlan filtering. > > 5) SKB_DROP_REASON_BRIDGE_SWDEV_NOT_ALLOWED_EGRESS: the packet is not > allowed to go out through the port which is offloaded by a hardware > switchdev, checked by nbp_switchdev_allowed_egress(). > > 6) SKB_DROP_REASON_BRIDGE_BOTH_PORT_ISOLATED: both source port and dest > port are in BR_ISOLATED state when bridge forwarding. > > Signed-off-by: xu xin <xu.xin16@xxxxxxxxxx> > Reviewed-by: Zhang Yunkai <zhang.yunkai@xxxxxxxxxx> > Reviewed-by: Yang Yang <yang.yang19@xxxxxxxxxx> > Cc: Xuexin Jiang <jiang.xuexin@xxxxxxxxxx> > --- > include/net/dropreason.h | 33 ++++++++++++++++++++++++++++++++ > net/bridge/br_forward.c | 49 +++++++++++++++++++++++++++++++++++++----------- > 2 files changed, 71 insertions(+), 11 deletions(-) > In addition to Jakub's comments, next time please CC bridge maintainers. I just noticed this patch now. Thanks, Nik