On 2023-02-02 16:43, Ido Schimmel wrote:
On Thu, Feb 02, 2023 at 08:37:08AM +0100, netdev@xxxxxxxxxxxxxxxxxxxx
wrote:
On 2023-01-31 20:25, Ido Schimmel wrote:
>
> Will try to review tomorrow, but it looks like this set is missing
> selftests. What about extending bridge_locked_port.sh?
I knew you would take this up. :-)
But I am not sure that it's so easy to have selftests here as it is
timing
based and it would take the 5+ minutes just waiting to test in the
stadard
case, and there is opnly support for mv88e6xxx driver with this patch
set.
The ageing time is configurable: See commit 081197591769 ("selftests:
net: bridge: Parameterize ageing timeout"). Please add test cases in
the
next version.
When I was looking at configuring the ageing time last time, my finding
was that the ageing time could not be set very low as there was some
part in the DSA layer etc, and confusion wrt units. I think the minimum
secured was like around 2 min. (not validated), which is not that much
of an improvement for fast testing. If you know what would be a good low
timeout to set, I would like to know.
