Nikolay Aleksandrov <razor@xxxxxxxxxxxxx> writes: > On 01/02/2023 19:28, Petr Machata wrote: >> @@ -668,6 +692,82 @@ void br_multicast_del_group_src(struct net_bridge_group_src *src, >> __br_multicast_del_group_src(src); >> } >> >> +static int >> +br_multicast_port_ngroups_inc_one(struct net_bridge_mcast_port *pmctx, >> + struct netlink_ext_ack *extack) >> +{ >> + if (pmctx->mdb_max_entries && >> + pmctx->mdb_n_entries >= pmctx->mdb_max_entries) > > These should be using *_ONCE() because of the next patch. > KCSAN might be sad otherwise. :) I didn't see any (relevant) KCSAN warnings on x86_64. But yeah, it (and the others you cited) should be *_ONCE.