On Thu, Jan 26, 2023 at 11:26:15PM -0800, Jakub Kicinski wrote: > On Fri, 27 Jan 2023 07:26:13 +0200 Leon Romanovsky wrote: > > > That'd be my preference too, FWIW. It's only the offload cases which > > > need this sort of fallback. > > > > Of course not, almost any error unwind path which sets extack will need it. > > I guess we can come up with scenarios where the new behavior would > be useful. But the fact is - your patch changes 4 places... ok, I'll rename. > > > See devlink as an example > > I don't know what part of devlink you mean at a quick scroll. I overlooked "return err" in the middle. You are right. Thanks
