On 26/01/2023 19:01, Petr Machata wrote: > Now that br_multicast_new_port_group() takes an extack argument, move > setting the extack there. The downside is that the error messages end > up being less specific (the function cannot distinguish between (S,G) > and (*,G) groups). However, the alternative is to check in the caller > whether the callee set the extack, and if it didn't, set it. But that > is only done when the callee is not exactly known. (E.g. in case of a > notifier invocation.) > > Signed-off-by: Petr Machata <petrm@xxxxxxxxxx> > Reviewed-by: Ido Schimmel <idosch@xxxxxxxxxx> > --- > net/bridge/br_mdb.c | 9 +++------ > net/bridge/br_multicast.c | 5 ++++- > 2 files changed, 7 insertions(+), 7 deletions(-) > Acked-by: Nikolay Aleksandrov <razor@xxxxxxxxxxxxx>