On Fri, 27 Jan 2023 00:44:57 +0200 Vladimir Oltean wrote: > On Thu, Jan 26, 2023 at 02:37:23PM -0800, Jakub Kicinski wrote: > > > I would somewhat prefer not doing this, and instead introducing a new > > > NL_SET_ERR_MSG_WEAK() of sorts. > > > > That'd be my preference too, FWIW. It's only the offload cases which > > need this sort of fallback. > > > > BTW Vladimir, I remember us discussing this. I was searching the > > archive as you sent this, but can't find the thread. Mostly curious > > whether I flip flipped on this or I'm not completely useless :) > > What we discussed was on a patch of mine fixing "if (!extack->_msg)" to > "if (extack && !extack->_msg)". I never proposed a new macro wrapper > (you did), but I didn't do it at the time because it was a patch for > "net", and I forgot to put a reminder for the next net->net-next merge. > https://lore.kernel.org/netdev/20220822182523.6821e176@xxxxxxxxxx/ > And from there, out of sight, out of mind. That explains it, I was running blame the message lines, not the if (). Thanks for digging it up!
