On Mon, 25 Apr 2022 16:25:07 +0200 Alaa Mohamed <eng.alaamohamedsoliman.am@xxxxxxxxx> wrote: > static int vxlan_fdb_parse(struct nlattr *tb[], struct vxlan_dev *vxlan, > union vxlan_addr *ip, __be16 *port, __be32 *src_vni, > - __be32 *vni, u32 *ifindex, u32 *nhid) > + __be32 *vni, u32 *ifindex, u32 *nhid, struct netlink_ext_ack *extack) > { > struct net *net = dev_net(vxlan->dev); > int err; > > if (tb[NDA_NH_ID] && (tb[NDA_DST] || tb[NDA_VNI] || tb[NDA_IFINDEX] || > - tb[NDA_PORT])) > - return -EINVAL; > + tb[NDA_PORT])) { > + NL_SET_ERR_MSG(extack, > + "DST, VNI, ifindex and port are mutually exclusive with NH_ID"); > + return -EINVAL; > + } The indentation is off here?