On Tue, Feb 22, 2022 at 02:28:18PM +0100, Hans Schultz wrote: > diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh > new file mode 100755 > index 000000000000..a8800e531d07 > --- /dev/null > +++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh > @@ -0,0 +1,180 @@ > +#!/bin/bash > +# SPDX-License-Identifier: GPL-2.0 > + > +ALL_TESTS="locked_port_ipv4 locked_port_ipv6 locked_port_vlan" > +NUM_NETIFS=4 > +CHECK_TC="no" > +source lib.sh > + > +h1_create() > +{ > + simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64 > + vrf_create "vrf-vlan-h1" > + ip link set dev vrf-vlan-h1 up > + vlan_create $h1 100 vrf-vlan-h1 198.51.100.1/24 ::ffff:c633:6401/64 Hi, Why did you change it from 2001:db8:3::1/64 to ::ffff:c633:6401/64? It was actually OK the first time... Anyway, looking at locked_port_vlan() I see that you are only testing IPv4 so you can just drop this address: vlan_create $h1 100 vrf-vlan-h1 198.51.100.1/24 Same for $h2 LGTM otherwise. Feel free to add my tag to the next version > +}