With this patch I'd like to fix an issue with vlan-aware bridges with a
single auto-port and a different MAC address on the bridge than its
port.
It took me a while to dig into this, and I hope to get some feedback and
would very much like to help out with more debugging if necessary and
hope this patch is a good first start.
Here's are the details I gathered:
When using devices with IFF_UNICAST_FLT support as bridge ports, they
sometimes don't get both MAC addresses added to their MAC filter
(seemingly limited to the time they're *added* to the bridge).
Since 2796d0c648c9 ("bridge: Automatically manage port promiscuous mode."),
bridges with `vlan_filtering 1` and only 1 auto-port don't set
IFF_PROMISC for unicast-filtering-capable ports.
This causes the bridge to "fail" if it has a different MAC than its
port, as the address is not added to the unicast filter when the port is
added.
This has become apparent with systemd's switch to
`MACAddressPolicy=persistent` which causes bridges to get different mac
addresses.
This is easily reproduced in qemu with `e1000` cards or virtio with
`vhost=off`.
Normally this should happen right when creating the bridge...
## This should be perfectly sufficient to reproduce this:
# ip link add br0 type bridge vlan_filtering 1
# ip link set eno1 master br0
## Setup addresses on the bridge and try to ping something
unless the port had IFF_PROMISC set when it was added to the bridge. In
that case it should be sufficient to simply re-plug the port.
# ip link set eno1 nomaster
# ip link set eno1 master br0
In my virtio-net based reproducer, I sprinkled some debugging output
into qemu (on top of the 6.0 tag from git, if you'd like the patch for a
quick test I'd be happy to provide it, too) and got the following:
----
VIRTIO_NET_CTRL_MAC
handle mac table set
mac_data.entries = 1
copying 1 single macs
in_use now 1
first_multi=1
mac_data.entries = 1 (multi)
copying 1 multi macs
now have: in_use=2 first_multi=1, uni_ovf=0 multi_ovf=0
mac 0: 52:54:00:12:34:56
mac 1: 01:00:5e:00:00:01
----
This shows only 1 unicast MAC (the one I assigned to the virtio NIC).
The bridge has a different MAC.
The quickest fix here is to change the mac address on the bridge while
the port is connected, this ends up re-syncing the MAC filter:
# ip link set br0 address 52:54:00:12:11:12
This created the following debug output:
----
VIRTIO_NET_CTRL_MAC
handle mac table set
mac_data.entries = 2
copying 2 single macs
in_use now 2
first_multi=2
mac_data.entries = 1 (multi)
copying 1 multi macs
now have: in_use=3 first_multi=2, uni_ovf=0 multi_ovf=0
mac 0: 52:54:00:12:34:56
mac 1: 52:54:00:12:11:12
mac 2: 01:00:5e:00:00:01
----
Above, both MAC addresses are visible in the mac table, and the bridge
works as expected.
Other noteworthy behaviors:
* setting `vlan_filtering 1` *after* adding a port does not cause the
issue.
* adding another auto-port puts all of the bridge's ports in promisc
mode and flushes the UC MAC list, networking works; removing the new
port resyncs the UC MAC list to correctly contain both addresses and
networking keeps working
So it seems to be limited to the time where the port is being *added* to
the bridge.
I've tested git-master, and proxmox kernels (ubuntu based) 5.11 and 5.4,
all of which experience the same behavior, patch applies cleanly to all
of them.
Wolfgang Bumiller (1):
net: bridge: sync fdb to new unicast-filtering ports
net/bridge/br_if.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
--
2.32.0
