On Thu, May 13, 2021 at 03:02:13PM +0300, Nikolay Aleksandrov wrote: > Nice work overall, thank you. I hope it was tested well. :) > It'd be great if later you could add some selftests. > > Cheers, > Nik Hi Nikolay, I think I found a way now to better deal with the protocol specific hlist_for_each_entry(), by using hlist_for_each() and a helper function, to reduce the duplicate code with br_{ip4,ip6}_multicast_get_rport_slot() as you suggested (and also removing duplicate code with br_{ip4,ip6}_multicast_mark_router()) and reworked patches 7 and 9 a bit for that... Sorry for the inconvience and my bad timing with your reviews. But thanks a lot for all your valuable feedback! Also netdevbpf patchwork had a few more remarks, they should hopefully be fixed now, too. Regards, Linus